Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how we store Musician Groups #90

Merged
merged 7 commits into from
Jan 26, 2025
Merged

Fix how we store Musician Groups #90

merged 7 commits into from
Jan 26, 2025

Conversation

owens1127
Copy link
Collaborator

@owens1127 owens1127 commented Jan 25, 2025 •
edited
Loading

Description

Fixes the schema to remove "group invites" and store group members differently

Motivation and Context

Closes #37

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Global styling changes
  • New package(s)
  • New dependencies
  • Project configuration
  • Environment variable update
  • Database migration
  • CI/CD changes (changing github actions or deployment scripts)

Checklist:

  • I verified my changes work in the local environment
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I verified my changes work in the preview environment

How has this been tested?

Screenshots (if appropriate):

@owens1127 owens1127 linked an issue Jan 25, 2025 that may be closed by this pull request
Replace groups invites objects in the database #37
Closed
@vercel Vercel
Copy link

vercel bot commented Jan 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dog-licensing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 0:28am

@owens1127 owens1127 changed the title first pass Fix how we store Musician Groups Jan 25, 2025
@owens1127 owens1127 marked this pull request as ready for review January 25, 2025 00:27
sanjana-singhania
sanjana-singhania reviewed Jan 25, 2025
View reviewed changes
packages/db/prisma/schema.prisma
updatedAt DateTime @updatedAt
}

model MusicianGroupMember {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we need to update this data on creation/update of its user (in case the wrong data is inputted), or is this more of a one time use data for registration?

Copy link
Member

@sanjana-singhania sanjana-singhania Jan 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's the former, where we want to display updated data in the admin dashboard so that the admin can view the updated information for group members, we may need to make a table to associate MusicianGroupMember with User.

mshvartsberg
mshvartsberg approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@mshvartsberg mshvartsberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@owens1127 owens1127 merged commit da0bc3a into main Jan 26, 2025
7 checks passed
@owens1127 owens1127 deleted the 37-replace-groups-invites-objects-in-the-database branch January 26, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjana-singhania sanjana-singhania sanjana-singhania left review comments

@mshvartsberg mshvartsberg mshvartsberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace groups invites objects in the database
3 participants
@owens1127 @mshvartsberg @sanjana-singhania